Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): chunked download to improve download speed #1459

Merged
merged 5 commits into from
Aug 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions util/downloader/chunk.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package downloader

import "fmt"

type chunk struct {
start, end int64
}

func createChunks(contentLength, totalChunks int64) []*chunk {
Ja7ad marked this conversation as resolved.
Show resolved Hide resolved
chunks := make([]*chunk, 0, totalChunks)
chunkSize := contentLength / totalChunks
Ja7ad marked this conversation as resolved.
Show resolved Hide resolved
for i := int64(0); i < totalChunks; i++ {
start := i * chunkSize
end := start + chunkSize - 1
// adjust the end for the last chunk
if i == totalChunks-1 {
end = contentLength - 1
}
chunks = append(chunks, &chunk{start: start, end: end})
}

return chunks
}

func (c *chunk) rangeHeader() string {
return fmt.Sprintf("bytes=%d-%d", c.start, c.end)
}

func (c *chunk) size() int64 {
return (c.end + 1) - c.start
}
112 changes: 112 additions & 0 deletions util/downloader/chunk_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
package downloader

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestCreateChunks(t *testing.T) {
tests := []struct {
contentLength int64
totalChunks int64
expected []*chunk
}{
{
contentLength: 181403648,
Ja7ad marked this conversation as resolved.
Show resolved Hide resolved
totalChunks: 16,
expected: []*chunk{
{start: 0, end: 11337727},
{start: 11337728, end: 22675455},
{start: 22675456, end: 34013183},
{start: 34013184, end: 45350911},
{start: 45350912, end: 56688639},
{start: 56688640, end: 68026367},
{start: 68026368, end: 79364095},
{start: 79364096, end: 90701823},
{start: 90701824, end: 102039551},
{start: 102039552, end: 113377279},
{start: 113377280, end: 124715007},
{start: 124715008, end: 136052735},
{start: 136052736, end: 147390463},
{start: 147390464, end: 158728191},
{start: 158728192, end: 170065919},
{start: 170065920, end: 181403647},
},
},
{
contentLength: 10,
totalChunks: 3,
expected: []*chunk{
{start: 0, end: 2},
{start: 3, end: 5},
{start: 6, end: 9},
},
},
{
contentLength: 10,
totalChunks: 1,
expected: []*chunk{
{start: 0, end: 9},
},
},
{
contentLength: 0,
totalChunks: 1,
expected: []*chunk{
{start: 0, end: -1},
},
},
}

for _, tt := range tests {
actual := createChunks(tt.contentLength, tt.totalChunks)
assert.Equal(t, tt.expected, actual)
}
}

func TestChunkRangeHeader(t *testing.T) {
tests := []struct {
chunk chunk
expected string
}{
{
chunk: chunk{start: 0, end: 499},
expected: "bytes=0-499",
},
{
chunk: chunk{start: 500, end: 999},
expected: "bytes=500-999",
},
}

for _, tt := range tests {
actual := tt.chunk.rangeHeader()
assert.Equal(t, tt.expected, actual)
}
}

func TestChunkSize(t *testing.T) {
tests := []struct {
chunk chunk
expected int64
}{
{
chunk: chunk{start: 0, end: 499},
expected: 500,
},
{
chunk: chunk{start: 500, end: 999},
expected: 500,
},
{
chunk: chunk{start: 0, end: 0},
expected: 1,
},
}

for _, tt := range tests {
actual := tt.chunk.size()
assert.Equal(t, tt.expected, actual)
}
}
Loading
Loading