fix(grpc): merge raw transaction methods to one rpc method #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
reviewed
Sep 10, 2024
b00f
reviewed
Sep 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
- Coverage 75.20% 75.16% -0.05%
==========================================
Files 223 231 +8
Lines 11654 12186 +532
==========================================
+ Hits 8764 9159 +395
- Misses 2461 2584 +123
- Partials 429 443 +14 |
b00f
approved these changes
Sep 12, 2024
|
@Ja7ad Are you sure this won't break the current behaviour of JSON-RPC? Please check |
I checked it. |
b00f
reviewed
Sep 14, 2024
b00f
reviewed
Sep 14, 2024
|
@b00f Done |
b00f
reviewed
Sep 20, 2024
|
@b00f Please check removed duplicate payload. |
b00f
reviewed
Sep 22, 2024
b00f
reviewed
Sep 22, 2024
|
I think we should find a way to use tx-builder here. |
fix(grpc): define fee as transaction field
b00f
reviewed
Sep 24, 2024
|
@b00f do we want to revert all changes in this PR or just remove deprecates for that four methods? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify Transaction APIs by Merging GetRawXTransaction Methods Using oneof in Protocol Buffers
Related issue(s)