Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(txpool): rename ConsumptionBlocks to ConsumptionWindow #1564

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Oct 20, 2024

Description

For better clarity, ConsumptionBlocks has been renamed to ConsumptionWindow. This change implies that consumption is measured within a specific window.

@b00f b00f requested a review from Ja7ad October 20, 2024 13:45
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (2c8bf99) to head (4b77035).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   75.10%   74.93%   -0.17%     
==========================================
  Files         233      234       +1     
  Lines       12134    12106      -28     
==========================================
- Hits         9113     9072      -41     
- Misses       2580     2586       +6     
- Partials      441      448       +7     

@Ja7ad Ja7ad linked an issue Oct 20, 2024 that may be closed by this pull request
@Ja7ad Ja7ad added this to the v1.6.0 milestone Oct 20, 2024
@Ja7ad Ja7ad merged commit 91c46b4 into pactus-project:main Oct 20, 2024
10 checks passed
@b00f b00f deleted the chore/tx-pool-rename-config branch October 21, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate consumption when committing a new block
2 participants