feat!: indexing public key #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
==========================================
+ Coverage 83.73% 83.77% +0.03%
==========================================
Files 155 155
Lines 7328 7358 +30
==========================================
+ Hits 6136 6164 +28
Misses 914 914
- Partials 278 280 +2 |
b00f
commented
Jul 31, 2023
types/tx/tx_test.go
Outdated
| @@ -304,14 +304,27 @@ func TestSortitionSanityCheck(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestSignBytes(t *testing.T) { | |||
| d, _ := hex.DecodeString("01f10c077fcc04f5ef819fc9d6080101d3e45d249a39d806a1faec2fd85820db340b98e30168fc72a1a961933e694439b2e3c8751d27de5ad3b9c3dc91b9c9b59b010c746573742073656e642d7478b53d79e156e9417e010fa21f2b2a96bee6be46fcd233295d2f697cdb9e782b6112ac01c80d0d9d64c2320664c77fa2a68d82fa4fcac04a3b565267685e90db1b01420285d2f8295683c138c092c209479983ba1591370778846681b7b558e0611776208c0718006311c84b4a113335c70d1f5c7c5dd93a5625c4af51c48847abd0b590c055306162d2a03ca1cbf7bcc1") | |||
| d, _ := hex.DecodeString("0001f10c077fcc04f5ef819fc9d6080101d3e45d249a39d806a1faec2fd85820db340b98e30168fc72a1a961933e694439b2e3c8751d27de5ad3b9c3dc91b9c9b59b010c746573742073656e642d7478b53d79e156e9417e010fa21f2b2a96bee6be46fcd233295d2f697cdb9e782b6112ac01c80d0d9d64c2320664c77fa2a68d82fa4fcac04a3b565267685e90db1b01420285d2f8295683c138c092c209479983ba1591370778846681b7b558e0611776208c0718006311c84b4a113335c70d1f5c7c5dd93a5625c4af51c48847abd0b590c055306162d2a03ca1cbf7bcc1") | |||
There was a problem hiding this comment.
d, _ := hex.DecodeString(
"01" + // version
"a1b2c3d4" + // stamp
"01" + // sequence
"01" + // fee
"01" + // payload type
"013333333333333333333333333333333333333333" + // sender
"012222222222222222222222222222222222222222" + // receiver
"01" + // fee
"00" + // memo
"b53d79e156e9417e010fa21f2b2a96bee6be46fcd233295d2f697cdb9e782b6112ac01c80d0d9d64c2320664c77fa2a6" + // sig
"8d82fa4fcac04a3b565267685e90db1b01420285d2f8295683c138c092c209479983ba1591370778846681b7b558e061" + // pub key
"1776208c0718006311c84b4a113335c70d1f5c7c5dd93a5625c4af51c48847abd0b590c055306162d2a03ca1cbf7bcc1") // pub key
```
b00f
commented
Jul 31, 2023
b00f
force-pushed
the
indexing-public-key
branch
from
a8412fe
to
f2b3999
Compare
kehiy
added
the
Breaking Changes
b00f
force-pushed
the
indexing-public-key
branch
from
f2b3999
to
64a32b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR indexes the public key by addresses and removes the public key from the transactions if it is already known.
This could potentially reduce the size of the blocks, since some transactions may already have known public keys.
BREAKING CHANGE