Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update buf and fixing proto generation issue #600

Merged
merged 3 commits into from
Jul 26, 2023
Merged

fix: update buf and fixing proto generation issue #600

merged 3 commits into from
Jul 26, 2023

Conversation

ZigBalthazar
Copy link
Contributor

Description

  • update buf@v1.8 to buf@v1.25.0
  • change the buf generate command to a short way
  • regenerate the protoBuffers with new command and version

Related issue(s)

@ZigBalthazar ZigBalthazar changed the title Fix proto Fix: proto generate Jul 26, 2023
@ZigBalthazar ZigBalthazar changed the title Fix: proto generate fix: proto generate Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #600 (ba578f2) into main (b9db7fc) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files         154      154           
  Lines        7277     7277           
=======================================
  Hits         6077     6077           
  Misses        918      918           
  Partials      282      282

@kehiy kehiy requested a review from b00f July 26, 2023 09:14
@kehiy
Copy link
Contributor

kehiy commented Jul 26, 2023

LGTM

@b00f b00f changed the title fix: proto generate fix: update buf and fixing proto generation issue Jul 26, 2023
@b00f b00f merged commit 8a65ea8 into pactus-project:main Jul 26, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No fields for transaction Fee
3 participants
@ZigBalthazar @kehiy @b00f