Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CalcualteFee in GRPC #601

Merged
merged 25 commits into from
Jul 30, 2023
Merged

feat: Add CalcualteFee in GRPC #601

merged 25 commits into from
Jul 30, 2023

Conversation

ZigBalthazar
Copy link
Contributor

@ZigBalthazar ZigBalthazar commented Jul 26, 2023 •
edited
Loading

Description

  • add calculateFee to GRPC
  • change wallet setFee and calcFee
  • change some typo
  • debug ./makefile

Related issue(s)

@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #601 (c626e2f) into main (d30f0a2) will decrease coverage by 0.17%.
The diff coverage is 53.12%.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   83.28%   83.11%   -0.17%     
==========================================
  Files         154      154              
  Lines        7275     7292      +17     
==========================================
+ Hits         6059     6061       +2     
- Misses        933      944      +11     
- Partials      283      287       +4

b00f
b00f approved these changes Jul 27, 2023
View reviewed changes
node/node.go Outdated Show resolved Hide resolved
state/facade.go Outdated Show resolved Hide resolved
state/mock.go Outdated Show resolved Hide resolved
state/state_test.go Outdated Show resolved Hide resolved
state/state_test.go Outdated Show resolved Hide resolved
wallet/client_test.go Outdated Show resolved Hide resolved
wallet/client.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jul 27, 2023

@ZigBalthazar

Thanks for this PR. It fix the CalculateFee related issues.

Still, some items need to be fixed:
1- Please update grpc-gateway.config.yaml
2- Make sure the linting check passes: make check
3- Fix the GUI issues.

@ZigBalthazar
Copy link
Contributor Author

@b00f

b00f
b00f requested changes Jul 30, 2023
View reviewed changes
cmd/gtk/utils.go Outdated Show resolved Hide resolved
node/node.go Outdated Show resolved Hide resolved
state/state_test.go Outdated Show resolved Hide resolved
@b00f
Copy link
Collaborator

b00f commented Jul 30, 2023

@ZigBalthazar
Thanks. Everything looks good to me. Just 2 small changes.

@b00f b00f merged commit 75b718e into pactus-project:main Jul 30, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00f b00f b00f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No fields for transaction Fee
2 participants
@ZigBalthazar @b00f