Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename SanityCheck to BasicCheck #643

Merged

Conversation

amirvalhalla
Copy link
Member

Description

rename SanityCheck methods name to BasicCheck

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@amirvalhalla amirvalhalla requested a review from b00f August 19, 2023 19:10
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #643 (6ba56a4) into main (af4b8e9) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   83.68%   83.70%   +0.01%     
==========================================
  Files         155      155              
  Lines        7293     7301       +8     
==========================================
+ Hits         6103     6111       +8     
  Misses        913      913              
  Partials      277      277              

@themantre themantre merged commit 24e2e5f into pactus-project:main Aug 20, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename SanityCheck methods to BasicCheck for better meaning
2 participants