Skip to content

Commit

Permalink
Merge pull request #371 from pagarme/fix/refactor-useragent-header-v3
Browse files Browse the repository at this point in the history 
Padronização do header X-PagarMe-User-Agent V3
  • Loading branch information
@sfwill-dev
sfwill-dev authored Sep 10, 2020
2 parents 97545f5 + 4c2a949 commit 38984ee
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 19 deletions.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"license": "MIT",
"require": {
"php": ">=5.4.0",
"guzzlehttp/guzzle": ">=5.3"
"guzzlehttp/guzzle": "5.3.4"
},
"require-dev": {
"ext-mbstring": "*",
Expand Down
2 changes: 1 addition & 1 deletion lib/PagarMe.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

class PagarMe
{
const VERSION = '3.8.1';
const VERSION = '3.8.2';

/**
* @param Client
Expand Down
2 changes: 1 addition & 1 deletion lib/RequestHeaders.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@ private function addUserAgentHeader($headers)
*/
private function getDefaultHeaders()
{
return 'pagarme-php/' . PagarMe::VERSION;
return 'pagarme-php/' . PagarMe::VERSION . ' php/' . phpversion();
}
}
2 changes: 2 additions & 0 deletions tests/acceptance/TransactionContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ public function thenTransactionMustBeRetriavable()
*/
public function thenTransactionPayablesMustBeRetriavable()
{
sleep(10);

$payables = self::getPagarMe()
->transaction()
->payables($this->transaction->getId());
Expand Down
24 changes: 12 additions & 12 deletions tests/acceptance/features/transaction.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ Feature: Transaction
Then a paid transaction must be created
Examples:
| number | holder | expiration | amount | installments |
| 4556425889100276 | João Silva | 0623 | 20000 | 1 |
| 4556425889100276 | João Silva | 0623 | 20000 | 3 |
| 5435375979338399 | Maria Silva | 0623 | 9900 | 7 |
| 30171632321686 | Pedro Silva | 0623 | 250 | 3 |
| 30171632321686 | Pedro Silva | 0623 | 250 | 1 |
| 341611978581611 | Cesar Silva | 0623 | 1337 | 12 |
| 6062825718246608 | Carla Silva | 0623 | 123456 | 10 |
| 6363685469431429 | Marta Silva | 0623 | 1000001 | 1 |
Expand All @@ -25,9 +25,9 @@ Feature: Transaction
And the transaction must be refunded
Examples:
| number | holder | expiration | amount | installments |
| 4539225249511077 | João Silva | 0623 | 1000 | 1 |
| 4539225249511077 | João Silva | 0623 | 1000 | 3 |
| 5326284789092430 | Maria Silva | 0623 | 1300 | 7 |
| 36016500807288 | Pedro Silva | 0623 | 1500 | 3 |
| 36016500807288 | Pedro Silva | 0623 | 1500 | 1 |
| 377255656605321 | Cesar Silva | 0623 | 2100 | 12 |
| 6062820984030620 | Carla Silva | 0623 | 4000 | 10 |
| 5041754009357643 | Marta Silva | 0623 | 5000 | 1 |
Expand All @@ -40,9 +40,9 @@ Feature: Transaction
And the transaction must be refunded with "<value>"
Examples:
| number | holder | expiration | amount | installments | value |
| 4539225249511077 | João Silva | 0623 | 1000 | 1 | 500 |
| 4539225249511077 | João Silva | 0623 | 1000 | 3 | 500 |
| 5326284789092430 | Maria Silva | 0623 | 1300 | 7 | 700 |
| 36016500807288 | Pedro Silva | 0623 | 1500 | 3 | 1300 |
| 36016500807288 | Pedro Silva | 0623 | 1500 | 1 | 1300 |
| 377255656605321 | Cesar Silva | 0623 | 2100 | 12 | 2000 |
| 6062820984030620 | Carla Silva | 0623 | 4000 | 10 | 1337 |
| 5041754009357643 | Marta Silva | 0623 | 5000 | 1 | 2500 |
Expand All @@ -54,9 +54,9 @@ Feature: Transaction
Then a authorized transaction must be created
Examples:
| number | holder | expiration | amount | installments |
| 4556655568781331 | João Silva | 0623 | 20000 | 1 |
| 4556655568781331 | João Silva | 0623 | 20000 | 3 |
| 5312843659611045 | Maria Silva | 0623 | 9900 | 7 |
| 38207356445228 | Pedro Silva | 0623 | 250 | 3 |
| 38207356445228 | Pedro Silva | 0623 | 250 | 1 |
| 371604330597394 | Cesar Silva | 0623 | 1337 | 12 |
| 6062824410079680 | Carla Silva | 0623 | 123456 | 10 |
| 5041754485700738 | Marta Silva | 0623 | 1000001 | 1 |
Expand All @@ -69,9 +69,9 @@ Feature: Transaction
Then a paid transaction must be created
Examples:
| number | holder | expiration | amount | installments |
| 4539927448873758 | João Silva | 0623 | 20000 | 1 |
| 4539927448873758 | João Silva | 0623 | 20000 | 3 |
| 5475972816746627 | Maria Silva | 0623 | 9900 | 7 |
| 30323500265699 | Pedro Silva | 0623 | 250 | 3 |
| 30323500265699 | Pedro Silva | 0623 | 250 | 1 |
| 371733354333913 | Cesar Silva | 0623 | 1337 | 12 |
| 6062822300852208 | Carla Silva | 0623 | 123456 | 10 |
| 4514161325131598 | Marta Silva | 0623 | 1000001 | 1 |
Expand All @@ -84,9 +84,9 @@ Feature: Transaction
Then a paid transaction must be created with "<capture>" paid amount
Examples:
| number | holder | expiration | amount | installments | capture |
| 4556111382970890 | João Silva | 0623 | 20000 | 1 | 14900 |
| 4556111382970890 | João Silva | 0623 | 20000 | 3 | 14900 |
| 5157798910157725 | Maria Silva | 0623 | 9900 | 7 | 9899 |
| 30257387840192 | Pedro Silva | 0623 | 250 | 3 | 230 |
| 30257387840192 | Pedro Silva | 0623 | 250 | 1 | 230 |
| 345066740083873 | Cesar Silva | 0623 | 1337 | 12 | 509 |
| 6062827431932910 | Carla Silva | 0623 | 123456 | 10 | 78910 |
| 4514164981119485 | Marta Silva | 0623 | 1000001 | 1 | 10001 |
Expand Down
10 changes: 6 additions & 4 deletions tests/unit/RequestHeadersTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ public function mustReturnCorrectHeaders()
$requestHeaders = new RequestHeaders();
$defaultHeaders = $requestHeaders->getSdkHeaders([]);
$expectedUserAgent = sprintf(
'pagarme-php/%s',
PagarMe::VERSION
'pagarme-php/%s php/%s',
PagarMe::VERSION,
phpversion()
);
$expectedHeaders = [
'X-PagarMe-User-Agent' => $expectedUserAgent,
Expand All @@ -33,8 +34,9 @@ public function mustReturnCorrectHeaders()
$sdkHeadersFilled = $requestHeaders->getSdkHeaders($filledHeaders);

$expectedUserAgent = sprintf(
'Magento/1.9.1.0 pagarme-php/%s',
PagarMe::VERSION
'Magento/1.9.1.0 pagarme-php/%s php/%s',
PagarMe::VERSION,
phpversion()
);
$expectedHeaders = [
'X-PagarMe-User-Agent' => $expectedUserAgent,
Expand Down

0 comments on commit 38984ee

Please sign in to comment.