Skip to content

Commit

Permalink
fix-kms-connections-config: Fix unused kms max connections configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
galales committed Oct 6, 2023
1 parent cb35d7d commit 1ac604b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
9 changes: 6 additions & 3 deletions src/main/resources/application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ authorization-server {
jwt-queue-url = ${JWT_QUEUE_URL}
jwt-fallback-bucket = ${JWT_FALLBACK_BUCKET}

signer-max-connections = 1024
signer-max-connections = ${?KMS_MAX_CONCURRENCY}

generated-jwt {
issuer = ${GENERATED_JWT_ISSUER}
m2m-audience = ${GENERATED_M2M_JWT_AUDIENCE}
Expand Down Expand Up @@ -86,6 +83,12 @@ services {

interop-commons {
isInternetFacing = true

kms {
max-concurrency = 1024
max-concurrency = ${?KMS_MAX_CONCURRENCY}
}

jwt {
public-keys {
urls = ${WELL_KNOWN_URLS}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ object ApplicationConfiguration {
val generatedM2mJwtDuration: Int =
config.getInt("authorization-server.generated-jwt.m2m-duration-seconds")

val signerMaxConnections: Int = config.getInt("authorization-server.signer-max-connections")

val clientAssertionAudience: Set[String] =
config.getString("authorization-server.client-assertion-audience").split(",").toSet.filter(_.nonEmpty)

Expand Down
6 changes: 5 additions & 1 deletion src/test/resources/application-test.conf
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ authorization-server {
}

client-assertion-audience = "client-assertion.audience" # Currently ignored, hardcoded in tests
signer-max-connections = 1024

rate-limiter {
limiter-group = "AUTHSERVER"
Expand All @@ -36,6 +35,11 @@ services {
}

interop-commons {

kms {
max-concurrency = 1024
}

jwt {
public-keys {
urls = "yadayada"
Expand Down

0 comments on commit 1ac604b

Please sign in to comment.