Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPANTT-120] feat: Implement Station Maintenances' APIs #32

Merged
merged 16 commits into from
Sep 19, 2024

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Sep 16, 2024

List of Changes

  • Configured Feign Client
  • Implemented client interface to api-config
  • Implemented, from selfcare-backoffice, APIs to menage station maintenances
  • Updated unit tests
  • Updated openapis
  • Excluded folder "util" from code review coverage

Motivation and Context

PPANTT-120

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Builder
@AllArgsConstructor
@NoArgsConstructor
public class MaintenanceHoursSummaryResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify the format for the fields of this class

Copy link
Collaborator Author

@svariant svariant Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hours are not in a specific date format, they're composed of hours on base 10 and minutes on base 60. Example: 30 and half hours is "30:30", 30 and a quarter is "30:15", 30 is "30" without minutes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there isn't a date format but the client doesn't know how pass the value (ex: "30:15"). Can you put the example and a description in the swagger please?

Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comments

@jacopocarlini
Copy link
Contributor

resolve the new issue of sonar

Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Sep 19, 2024

@svariant svariant merged commit 05a99e4 into main Sep 19, 2024
10 of 11 checks passed
@svariant svariant deleted the PPANTT-120-station-maintenances-apis branch September 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants