forked from cedbossneo/WheelLogAndroid
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.8 enhanced for Pebble beep support #4
Open
MacPara
wants to merge
14
commits into
palachzzz:master
Choose a base branch
from
MacPara:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved MCM useRatio processing from MainActivity to Preferences OnChange processing Updated Gradle configuration to compile with Gradle 4.4, still a few deprecated statements in there Inmotion V8 comms might still be broken, I have no wheel to try it
bugs fixed to V2.0.6
upon pressing volume keys when in focus or via Pebble watch Select button.
Sorry about the conflicts. It should be straight forward to clean these up. If not I can answer any questions you might have! |
I fixed a minor bug in the previous version/pull-request that did not update the Version tag when the preference menu was opened again. |
Hi, sorry I'm in business trip till 7 June, I will check it after return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We developed in parallel it seemed, so this is a bit trickier than before. I tried to merge all your recent 2.0.8 enhancements into my code base so I wouldn't undo anything you have done. This should contain V10 support, MAC address edit, etc.
I had added Pebble beep support for GW wheels (KS support existed before).
Also added a version number in the settings preferences page, that updates from the app gradle settings, so it would be easier for folks to check what version they're running.