Omnibar does not return focus when opened and closed for the second time

[evansjohnson]

Steps to reproduce

https://blueprintjs.com/docs/#select/omnibar

• Tab to button that opens omnibar
• Hit enter
• Close omnibar
• See focus return to button
• Repeat
• See focus does not return to button

Actual behavior

From quick debugging, it looks like the dialog is trying to return focus to the input rendered in the omnibar dialog when closing the second time. This is due to thinking that the input is the "last focused element" the second time it opens.

Expected behavior

Omnibar should return focus since it does not override the Dialog's default shouldReturnFocusOnClose={true}. This is likely actually a Dialog issue but I did not attempt to reproduce outside of Omnibar yet.

Possible solution

Make sure the input that is rendered in the Dialog is not considered the last focused element before the Dialog opens