Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect onKeyUp props not being correctly called #6917

Open
donghee214 opened this issue Jul 18, 2024 · 0 comments
Open

MultiSelect onKeyUp props not being correctly called #6917

donghee214 opened this issue Jul 18, 2024 · 0 comments

Comments

@donghee214
Copy link
Contributor

The incorrect prop is being called here when the keyUp event is called:

this.props.popoverTargetProps?.onKeyDown?.(e);

Environment

  • Package version(s): @blueprintjs/select-version": "5.2.1"
  • Operating System: MacOS Sonoma 14.5 (23F79)
  • Browser name and version: Chrome 126.0.6478.127 (arm64)

Code Sandbox

Will add briefly

Steps to reproduce

  1. Create MultiSelect Component
  2. Pass in onKeyUp Prop
  3. Navigate through the dropdown using keys

Actual behavior

onKeyDown prop is called on keyUp events

Expected behavior

onKeyDown prop is called on keyDown events

Possible solution

Replace here with onKeyUp. THIS WOULD TECHNICALLY BE A BREAKING CHANGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant