Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /reset w.r.t. OWASP #816

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Improve /reset w.r.t. OWASP #816

merged 1 commit into from
Jul 19, 2023

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jul 19, 2023

  • no longer send a new token upon receiving an expired token
  • no longer auto-login on successful reset password (backwards compat config variable added)
  • no longer send identity/email information as part of query params in unauthenticated requests
  • add Referrer-Policy="no-referrer" as suggested by OWASP

Minor improvements to API doc.

closes #281

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3bbd996) 98.16% compared to head (2ee8ba1) 98.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   98.16%   98.15%   -0.01%     
==========================================
  Files          34       34              
  Lines        4460     4456       -4     
==========================================
- Hits         4378     4374       -4     
  Misses         82       82              
Impacted Files Coverage Δ
flask_security/forms.py 99.21% <ø> (ø)
flask_security/core.py 98.61% <100.00%> (+<0.01%) ⬆️
flask_security/views.py 98.77% <100.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- no longer send a new token upon receiving an expired token
- no longer auto-login on successful reset password (backwards compat config variable added)
- no longer send identity/email information as part of query params in unauthenticated requests
- add Referrer-Policy="no-referrer" as suggested by OWASP

Minor improvements to API doc.

closes #281
@jwag956 jwag956 merged commit ed5c824 into master Jul 19, 2023
15 checks passed
@jwag956 jwag956 deleted the reset281 branch July 19, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Reset password email can be exploited
1 participant