A better fix for open redirect vulnerability. #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the few cases where user input is used for redirecting (via the 'next' parameter) pull apart the URL and quote the path. This will render any of the bizarre URLs that are relative according to the spec, but interpreted as absolute by many browsers definitely relative (and harmless). Remove the previous fix including REDIRECT_VALIDATE_MODE and REDIRECT_VALIDATE_RE configuration variables. The Werkzeug default of sending relative URLs in Location header was restored as well.
jwag956
force-pushed
the
893p2redirect
branch
from
bcdcc2f
to
53e9d5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 98.37% 98.38% +0.01%
==========================================
Files 34 34
Lines 4487 4465 -22
==========================================
- Hits 4414 4393 -21
+ Misses 73 72 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the few cases where user input is used for redirecting (via the 'next' parameter) pull apart the URL and quote the path. This will render any of the bizarre URLs that are relative according to the spec, but interpreted as absolute by many browsers definitely relative (and harmless).
Remove the previous fix including REDIRECT_VALIDATE_MODE and REDIRECT_VALIDATE_RE configuration variables. The Werkzeug default of sending relative URLs in Location header was restored as well.
closes #893