Improve oauth glue #915
Merged
Improve oauth glue #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 34 35 +1
Lines 4474 4508 +34
==========================================
+ Hits 4402 4436 +34
Misses 72 72 ☔ View full report in Codecov by Sentry. |
jwag956
force-pushed
the
oauthazure
branch
2 times, most recently
from
338448a
to
1b20447
Compare
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that we now store any 'next' value in the session (fs_oauth_next). To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX. Convert our Github and Google pre-defined providers to the new class method. Add support for Azure in the Oauth example code. Change OAUTH_HANDSHAKE_ERROR to include info from authlib. closes #912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers e.g. Azure require the redirect URL to match exactly - including query params etc. To support that we now store any 'next' value in the session (fs_oauth_next).
To enable better debugging a class that can be subclassed for each provider - the auth_response_error() method can be subclassed for better debugging/UX.
Convert our Github and Google pre-defined providers to the new class method.
Add support for Azure in the Oauth example code.
Change OAUTH_HANDSHAKE_ERROR to include info from authlib.
closes #912