Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topper and paymonade #10024

Merged
merged 28 commits into from
Jul 19, 2024

Conversation

ChefBingbong
Copy link
Contributor

@ChefBingbong ChefBingbong commented Jun 15, 2024


PR-Codex overview

The focus of this PR is to update the BuyCrypto feature with new provider availabilities, transaction fee details, and translations.

Detailed summary

  • Added a new provider Topper in the BuyCrypto feature
  • Updated transaction fee details component
  • Added new translations for BuyCrypto feature
  • Refactored and optimized code for better performance

The following files were skipped due to too many changes: apps/web/src/views/BuyCrypto/containers/BuyCryptoForm.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 11:49am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 11:49am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 11:49am
blog ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 11:49am
bridge ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 11:49am
games ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 11:49am
uikit ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 11:49am

Copy link

changeset-bot bot commented Jun 15, 2024

⚠️ No Changeset found

Latest commit: 124d506

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

export const chainIdToTopperNetworkId: { [id: number]: string } = {
[OnRampChainId.ETHEREUM]: 'ethereum',
[OnRampChainId.ARBITRUM_ONE]: 'arbitrum',
0: 'bitcoin',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bitcoin is 0?

Copy link
Contributor Author

@ChefBingbong ChefBingbong Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btc doesnt have a chanid so its a work around so that it works with our token list and chaind mapings system

@ChefBingbong ChefBingbong merged commit ed8f357 into develop Jul 19, 2024
19 checks passed
@ChefBingbong ChefBingbong deleted the feat--topper-&-paymonade-onramp-FE-integration branch July 19, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants