Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use callback on aptos query select #10816

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 13, 2024


PR-Codex overview

This PR primarily focuses on optimizing the selection functions across various components by replacing inline functions with useCallback. This change enhances performance by memoizing the functions, preventing unnecessary re-renders.

Detailed summary

  • Replaced inline select functions with useCallback in:
    • apps/aptos/components/SearchModal/CurrencyList.tsx
    • apps/aptos/components/Farms/components/FarmCard/ApyButton.tsx
    • apps/aptos/components/Farms/components/FarmTable/Actions/StakedAction.tsx
    • apps/aptos/components/Pools/hooks/usePoolsList.ts
    • apps/aptos/components/Liquidity/hooks/useLPPairsHaveBalance.ts
    • apps/aptos/views/Ifos/hooks/useIfoUserInfo.ts
    • apps/aptos/hooks/Tokens.ts
    • apps/aptos/views/Ifos/hooks/useIfoResources.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 3:36pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blog ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm
games ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm
web ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 3:36pm

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: b0513c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant