Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove turkey banner and spread reduce #10840

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 19, 2024


PR-Codex overview

This PR primarily focuses on optimizing the use of the reduce method across various components by replacing object spread syntax with direct assignments to improve performance and readability.

Detailed summary

  • In pools.ts, changed return of reduce to use accum.push.
  • In StableV3Selector.tsx, modified reduce to directly assign values instead of spreading.
  • Similar changes made in IncreaseLiquidityV3.tsx, V3FormView/index.tsx, and FeeSelector.tsx.
  • Updated maxAmounts calculation in AddStableLiquidity/index.tsx to use useMemo with direct assignments.
  • Refactored useMultipleBannerConfig to remove a banner entry.
  • Enhanced usePositionsByUserFarms and useV3BoostedLiquidityX to use direct assignments in reduce.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: 8e55da8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:11am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am
blog ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am
games ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:11am

@chefjackson
Copy link
Collaborator

may I check why do we need to update the spread use case?

@memoyil
Copy link
Collaborator Author

memoyil commented Oct 21, 2024

may I check why do we need to update the spread use case?

@chefjackson This is for to reduce memory footprint to not create intermediate arrays, it was supposed to be changed in #10774 like (e11a190, 37549de, d6b4379, 774db26), i included here but if you want i can do it in seperate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants