Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump up react query 5.59.15 #10841

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 19, 2024


PR-Codex overview

This PR updates the version of @tanstack/react-query across multiple package files from ^5.52.1 to catalog:, which points to the latest version 5.59.15. This ensures all packages are using the most recent version of the library for improved performance and features.

Detailed summary

  • Updated @tanstack/react-query from ^5.52.1 to catalog: in:
    • pnpm-workspace.yaml
    • packages/wagmi/package.json
    • apps/blog/package.json
    • apps/games/package.json
    • apps/web/package.json
    • packages/awgmi/package.json
    • apps/gamification/package.json
    • apps/aptos/package.json
  • Updated @tanstack/react-query version in pnpm-lock.yaml to 5.59.15.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: 0c6877f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:31am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:31am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:31am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:31am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:31am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 5:31am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 5:31am

Copy link

socket-security bot commented Oct 19, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Contributor

@chef-ryan chef-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need clear reasons to upgrade these libraries; otherwise, it will increase testing workload and uncertainty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we bump up this?
Any security fixes or ? ~

@chefjackson
Copy link
Collaborator

we can move it to category

@memoyil
Copy link
Collaborator Author

memoyil commented Oct 21, 2024

We may need clear reasons to upgrade these libraries; otherwise, it will increase testing workload and uncertainty.

There are fixes + perf improvements between and 5.52 and 5.59 (https://github.com/tanstack/query/releases) and we should do it regulary otherwise if library version is too stale in the codebase it might be too hard to bump up (potential breaking changes and dependency on other libraries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants