fix: 🐛 Fix the pool tvl display when amount > 1B #10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chef-ryan
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin and
chef-eric
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
memoyil
reviewed
Oct 30, 2024
chefjackson
reviewed
Oct 30, 2024
| <Text color="warning" as="span"> | ||
| {t('TVL and APR data may not be reflected correctly due to technical limitation, please refer to')}{' '} | ||
| <TextLink target="_blank" href={link}> | ||
| {t('this link')} |
chefjackson
requested changes
Oct 30, 2024
| return null | ||
| } | ||
| // const pairAddress = Pair.getAddress(token0.wrapped, token1.wrapped) | ||
| const link = `https://pancakeswap.finance/info/v3/pairs/${id}` |
There was a problem hiding this comment.
it could be v2/SS and could be different chain
1. fix links for ss and v2 2. fix text 3. fix typo
chefjackson
reviewed
Oct 31, 2024
|
|
||
| const version = `${protocol === Protocol.V3 ? '/v3/' : ''}` | ||
| const stableSwap = `${protocol === Protocol.STABLE ? '?type=stableSwap' : ''}` | ||
| const link = `https://pancakeswap.finance/info/${version}${chain}/pairs/${id}${stableSwap}` |
There was a problem hiding this comment.
better use relative link
chefjackson
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a new component,
PoolTvlWarning, to display warnings about TVL and APR data accuracy in thePoolInfoview. It also updates localization strings to include a new warning message.Detailed summary
PoolTvlWarningcomponent inPoolInfo.tsx.PoolTvlWarninginto thePoolInfolayout.translations.jsonto include: