Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add debounce and abort signal to position manager, make calls per chain instead of per gauge #10906

Merged

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Nov 4, 2024


PR-Codex overview

This PR focuses on enhancing the fetchPositionManager and getPositionManagerName functions to support cancellation through AbortSignal. It also updates the useQuery hooks in various components to utilize these changes, improving error handling and performance.

Detailed summary

  • Updated fetchPositionManager to accept an optional signal parameter for cancellation.
  • Improved error handling in fetchPositionManager and getPositionManagerName.
  • Modified useQuery in usePositionManager and usePositionManagerName to use the new signal parameter.
  • Enhanced useFilteredGauges to handle asynchronous fetching with cancellation.
  • Added anySignal utility function to manage multiple abort signals.
  • Updated the getPositionManagerName function to handle an optional vaults parameter and signal.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: fb3f96f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 9:03am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am
blog ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am
bridge ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am
games ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am
gamification ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am
uikit ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 9:03am

@memoyil memoyil marked this pull request as ready for review November 4, 2024 08:56
@memoyil memoyil changed the title feat: Add debounce and abort signal to position manager feat: Add debounce and abort signal to position manager, make calls per chain instead of per gauge Nov 4, 2024
@ChefMomota ChefMomota merged commit d69cdda into develop Nov 4, 2024
20 checks passed
@ChefMomota ChefMomota deleted the feature/feat_add_debounce_abort_signal_to_position_manager branch November 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants