fix: Address comparation bug #10912
fix: Address comparation bug #10912
Conversation
chef-ryan
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin and
chef-eric
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| @@ -38,7 +38,9 @@ export const getAllGauges = async ( | |||
| if (!killed) allActiveGaugeInfos = allActiveGaugeInfos.filter((gauge) => !gauge.killed) | |||
|
|
|||
| const allGaugeInfoConfigs = allActiveGaugeInfos.reduce((prev, gauge) => { | |||
| const filters = presets.filter((p) => p.address === gauge.pairAddress && Number(p.chainId) === gauge.chainId) | |||
| const filters = presets.filter( | |||
| (p) => p.address.toLowerCase() === gauge.pairAddress.toLowerCase() && Number(p.chainId) === gauge.chainId, | |||
There was a problem hiding this comment.
use isAddressEqual from utils
There was a problem hiding this comment.
@chef-ryan @chefjackson I have done it for web package #10916 please review
PR-Codex overview
This PR focuses on improving the filter logic in the
getAllGauges.tsfile by ensuring case-insensitive comparison forgauge.pairAddress.Detailed summary
filtersdefinition to usetoLowerCase()forgauge.pairAddressandp.addressto ensure case-insensitive matching.filterfunction for better readability by spreading it across multiple lines.