Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typos in translation keys across locales #10920

Conversation

goffxnca
Copy link
Contributor

@goffxnca goffxnca commented Nov 6, 2024


PR-Codex overview

This PR focuses on correcting a typo in the text displayed for inactive collections in the MarketPageTitle component and updating the corresponding translation in the localization file.

Detailed summary

  • Fixed typo: Changed "inactived" to "inactive" in the MarketPageTitle.tsx file.
  • Updated the translation entry in translations.json to reflect the corrected text.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 2176a8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
blog ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
bridge ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
games ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
gamification ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
uikit ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am
web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 3:23am

Copy link

vercel bot commented Nov 6, 2024

@goffxnca is attempting to deploy a commit to the PancakeSwap Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@memoyil memoyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont change the translation language jsons directly, but change keys in the translation.json instead

@pull-request-size pull-request-size bot added size/XS and removed size/M labels Nov 6, 2024
@goffxnca
Copy link
Contributor Author

goffxnca commented Nov 6, 2024

Dont change the translation language jsons directly, but change keys in the translation.json instead

Hi memoyil, thanks for the feedback! I made the updates and dropped the changes to the locale files, so now the PR has only translations.json and MarketPageTitle.tsx with the corrected key. just noticed Crowdin is in place, so hopefully Crowdin will handle updating the locale files to the new key after.

@goffxnca goffxnca requested a review from memoyil November 6, 2024 19:47
@chefjackson chefjackson merged commit dc2d3d5 into pancakeswap:develop Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants