Audit/hexens 2nd round part2.2 #209
Merged
+230
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownableship is transferred by mistake
|
…anager ownership transfer
chefburger
force-pushed
the
audit/hexens-2nd-round-part2.2
branch
from
b4bc2a0
to
f5df2d4
Compare
chef-omelette
requested changes
Nov 7, 2024
| abstract contract PoolManagerOwnable2Step is IPoolManagerOwner { | ||
| error NotPendingPoolManagerOwner(); | ||
|
|
||
| address private _pendingPoolManagerOwner; |
There was a problem hiding this comment.
why not just make it public?
There was a problem hiding this comment.
loll, actually refer this from OZ@Ownable2Step
src/base/PoolManagerOwnable2Step.sol
Outdated
|
|
||
| address private _pendingPoolManagerOwner; | ||
|
|
||
| modifier isFromPendingPoolManagerOwner() { |
There was a problem hiding this comment.
prefer naming it to onlyPendingPoolManagerOwner
ChefSnoopy
reviewed
Nov 7, 2024
| */ | ||
| abstract contract PoolManagerOwnable2Step is IPoolManagerOwner { | ||
| error NotPendingPoolManagerOwner(); | ||
|
|
There was a problem hiding this comment.
do we need event here ?
like "event OwnershipTransferStarted(address indexed previousOwner, address indexed newOwner);"
ChefSnoopy
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.