ci: update reciprocalAmount logic based on feedback #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
chefburger
approved these changes
Jun 6, 2024
ChefMist
added a commit
that referenced
this pull request
Jun 6, 2024
* chore: updated v4-core dependency * feat: update to include vault.sync mechanism * feat: updated with flip balanceDelta and exactInput * forge install: pancake-v4-core * feat: apply the vault renaming to v4-periphery * ci: update reciprocalAmount logic based on feedback (#34) --------- Co-authored-by: chefburger <burger@pancakeswap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based on feedback on pancakeswap/pancake-v4-periphery#32 (comment)
Though took the chance to refactor a bit more and added more comments. can't think of a better name for
reciprocalAmountthough 😆