Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support batch modify liquidities for Bin #72

Closed
wants to merge 8 commits into from

Conversation

ChefSnoopy
Copy link
Collaborator

No description provided.

@ChefSnoopy
Copy link
Collaborator Author

We still keep the single external functions, addLiquidity and removeLiquidity in this version
this is the gas comparison.

Function Gas
testAddLiquidityWithActiveId 901871
testBatch_AddLiquidityWithActiveId_WithoutCloseCurrency 900913
testRemoveLiquidityWithActiveId_ThreeBins 212997
testBatch_RemoveLiquidityWithActiveId_ThreeBins_WithoutCloseCurrency 212335

So single action gas is higher than using modifyLiquidities without close currency.

@ChefSnoopy ChefSnoopy closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant