feat: update universal router to use create3 deployment #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
commented
Oct 29, 2024
| @@ -0,0 +1 @@ | |||
| (0x31c2F6fcFf4F8759b3Bd5Bf0e1084A055615c768,0xae13d989daC2f0dEbFf460aC112a837C89BAa7cd,0x6725F303b657a9451d8BA641348b6761A6CC7a17,0x0BFbCF9fa4f9C56B0F40a671Ad40E0805A091865,0x41ff9AA7e16B8B1a8a8dc4f0eFacd93D02d071c9,0xd0d4c4cd0848c93cb4fd1f498d7013ee6bfb25783ea21593d5834f5d250ece66,0x6ce8eb472fa82df5469c6ab6d485f17c3ad13c8cd7af59b3d4a8026c5ce0f7e2,0xe6A00f8b819244e8Ab9Ea930e46449C2F20B6609,0x0A548d59D04096Bc01206D58C3D63c478e1e06dB,0x0a125Bb36e409957Ed951eF1FBe20e81D682EAb6,0x26Ca53c8C5CE90E22aA1FadDA68AB9a08f7BA06f,0x1DF0be383e9d17DA4448E57712849aBE5b3Fa33b,0x427bF5b37357632377eCbEC9de3626C71A5396c1,0x095bd2cf90ef113aa8c53904cE54C17f4583046d,0x26008c91a2D47147d6739db3fFd3598A27da859d) | |||
There was a problem hiding this comment.
use file for constructor args as universal router has a lot of params
chefburger
reviewed
Oct 30, 2024
README.md
Outdated
There was a problem hiding this comment.
oh, will update v4-core REAME as well
|
Maybe one more thing: should we add comments to remind that the new owner must call acceptOwnership to finish the owner transfer since Ownable2Step is used ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates universal router to use PCS create3 factory - https://github.com/pancakeswap/pancake-create3-factory