Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enums to reflect typing spec changes #1020

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

hauntsaninja
Copy link
Contributor

See https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members

python/typing-council#11

The next version of mypy will obey the spec change: python/mypy#18068

pyright already requires this

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Oct 30, 2024

I think the CI is failing on Windows because of a pyright issue that was just fixed. Can you update the pyproject.toml to require pyright >= 1.1.387 ?

@hauntsaninja hauntsaninja mentioned this pull request Oct 30, 2024
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hauntsaninja

@Dr-Irv Dr-Irv merged commit 1a314a0 into pandas-dev:main Oct 30, 2024
10 checks passed
@hauntsaninja hauntsaninja deleted the enum branch October 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants