Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slice/Hashable overlap. Update mypy and pyright #1021

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Oct 30, 2024

Also makes stubs compliant with mypy 1.13.0 and pyright 1.1.387 .

Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great seeing far fewer ignore comments :)

pandas-stubs/core/arrays/datetimelike.pyi Show resolved Hide resolved
pandas-stubs/core/groupby/generic.pyi Outdated Show resolved Hide resolved
pandas-stubs/core/groupby/groupby.pyi Show resolved Hide resolved
@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Oct 31, 2024

@twoertwein updates based on your comments for you to review

Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me! Just need to rebase

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Nov 1, 2024

Thank you, looks good to me! Just need to rebase

done in commit b5ba2ed

@twoertwein twoertwein merged commit fd3bc04 into pandas-dev:main Nov 1, 2024
10 checks passed
@twoertwein
Copy link
Member

Thank you @Dr-Irv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync with upcoming typeshed changes making slice hashable
2 participants