Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a number of packages #502

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add a number of packages #502

merged 2 commits into from
Nov 21, 2023

Conversation

dcherian
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Try on Mybinder.org!

@pangeo-bot
Copy link
Collaborator

/condalock
Automatically locking new conda environment, building, and testing images...

weiji14
weiji14 reviewed Nov 21, 2023
View reviewed changes
pangeo-notebook/environment.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions increase the pangeo-notebook's docker image size from 5.38GB (at 2023.11.19) to 5.39GB. Acceptable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine at some point a review of packages and their disk space footprint might be a good idea

scottyhq
scottyhq approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds:

- black
- cf_xarray
- ipdb
- jupyterlab_code_formatter
- jupyterlab-myst
- line_profiler
- memory_profiler
- watermark
- xxhash

@scottyhq scottyhq merged commit 6caa275 into pangeo-data:master Nov 21, 2023
5 checks passed
@dcherian dcherian deleted the updates branch November 21, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 left review comments

@scottyhq scottyhq scottyhq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcherian @pangeo-bot @scottyhq @weiji14