-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CUDA from 11.8 to 12.0 #514
Conversation
Update Pytorch, Torchvision and Tensorflow to use CUDA 12.0 builds. Also bumped pytorch from 2.0.0 to 2.1.0, torchvision from 0.15.1 to 0.16.1 and tensorflow from 2.14.0 to 2.15.0 because lower versions only has CUDA 11.8 on conda-forge.
/condalock |
/condalock |
/condalock |
Hmm, conda-lock is not handling the
Need to see what's going on. |
Manually re-locking
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
…ook" This reverts commit 7658847.
Bumps [conda-lock](https://github.com/conda/conda-lock) from 2.3.0 to 2.5.5. - [Release notes](https://github.com/conda/conda-lock/releases) - [Commits](conda/conda-lock@v2.3.0...v2.5.5)
This comment was marked as duplicate.
This comment was marked as duplicate.
Bumps [conda](https://github.com/conda/conda) from 23.11.0 to 24.1.2. - [Release notes](https://github.com/conda/conda/releases) - [Changelog](https://github.com/conda/conda/blob/master/CHANGELOG.md) - [Commits](conda/conda@23.11.0...24.1.2)
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This reverts commit 4d26a19.
Update: Finally, after setting a |
Ah ok, can't just change the timeout in this PR, might need to have it on the |
This comment has been minimized.
This comment has been minimized.
This comment was marked as duplicate.
This comment was marked as duplicate.
Oh wow, now the locking takes just 2min 30s 😅 Anyways, this is finally ready for review! Edit: Not so fast, the lockfiles show cpu versions getting pulled in instead of cuda versions, see #514 (comment) |
pytorch-notebook/conda-lock.yml
Outdated
networkx: '' | ||
numpy: '>=1.23.5,<2.0a0' | ||
python: '>=3.11,<3.12.0a0' | ||
python_abi: 3.11.* | ||
sleef: '>=3.5.1,<4.0a0' | ||
sympy: '' | ||
typing_extensions: '' | ||
url: https://conda.anaconda.org/conda-forge/linux-64/pytorch-2.3.0-cuda118_py311h6c9cb27_300.conda | ||
url: https://conda.anaconda.org/conda-forge/linux-64/pytorch-2.3.0-cpu_mkl_py311h9835ca6_100.conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the cpu version is getting pulled in, might need to actually do the cuda*
pin on the build number still...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: pytorch-2.3.0-cuda120*
is pulled in now, see #514 (comment)
This reverts commit 12da355.
This comment was marked as duplicate.
This comment was marked as duplicate.
Partial revert of 537c27f
This comment was marked as duplicate.
This comment was marked as duplicate.
Pin minimum version of CUDA to 12.0, instead of specifying exact pin on 12.0
This comment was marked as duplicate.
This comment was marked as duplicate.
Found a clue after creating a
Running
Need to play around with relaxing the |
/condalock |
@@ -9234,10 +9394,10 @@ package: | |||
sleef: '>=3.5.1,<4.0a0' | |||
sympy: '' | |||
typing_extensions: '' | |||
url: https://conda.anaconda.org/conda-forge/linux-64/pytorch-2.3.0-cuda118_py311h6c9cb27_300.conda | |||
url: https://conda.anaconda.org/conda-forge/linux-64/pytorch-2.3.0-cuda120_py311h2667f23_300.conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, finally getting the cuda120 build version of pytorch!!!
Thanks for sticking with this @weiji14 ! Seems like adding tensorflow: 11.3 -> 10.7GB I'm going to go ahead and merge. |
Yeah, I want to say that the
Yes, this is because conda-forge has split the |
CUDA 12.0 migration across conda-forge is practically complete (see https://conda-forge.org/status/#cuda120), so we can start updating to a newer version of CUDA!
Note:
Changes in this PR:
References:
Supersedes #505, Fixes #489