Add anywidget to pangeo-notebook #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom jupyter widgets made easy! Repo at https://github.com/manzt/anywidget
|
|
|
/condalock |
2 tasks
rabernat
approved these changes
Apr 2, 2024
|
Can someone open the binder link to test and see if |
|
Binder build doesn't seem to work |
|
Hmm, the |
|
Oh wait, I just noticed this line: Why is it using Python 3.1, is there some Python 3.10 bug somewhere? |
|
/condalock |
Good catch, that is an unrelated bug that seems to have been happening since we started using python 3.10 see #530 |
scottyhq
reviewed
Apr 3, 2024
| @@ -4,6 +4,7 @@ channels: | |||
| - nodefaults | |||
| dependencies: | |||
| - adlfs | |||
| - anywidget | |||
There was a problem hiding this comment.
I still don't understand why we don't just add lonboard here. it seems like the whole matching hub/client versions might just be relevant if running jupyterhub on a single machine (with a common default env) versus k8s? maybe i'm missing something, but for the k8s case I thought all packages and versions available to a user are defined here and nowhere else.
There was a problem hiding this comment.
Well, it depends on how much people want to use lonboard. I've only added anywidget to keep things lightweight-ish, but if lonboard is something a lot of people want to use, then we could add it directly also. Just that I work at the same company developing lonboard, so don't want to be too pushy 😉
Note that the conda-forge version of lonboard at https://anaconda.org/conda-forge/lonboard/files?version=0.7.1 sets a minimum pin of anywidget >=0.9.0, so I don't think we can be confident about matching compatible lonboard and anywidget versions, even if we do add lonboard to the environment.yml file here.
Merged
|
/condalock |
|
Superseded by #532. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom jupyter widgets made easy! Repo at https://github.com/manzt/anywidget
Fixes #520.