Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter-sshd-proxy #585

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Add jupyter-sshd-proxy #585

merged 3 commits into from
Oct 10, 2024

Conversation

jbusecke
Copy link
Collaborator

@jbusecke jbusecke commented Oct 1, 2024

Over at LEAP we have been testing https://github.com/yuvipanda/jupyter-sshd-proxy (thanks @yuvipanda )and it works really nicely to connect to cloud hubs e.g. using vscode. I think this is a pretty broadly requested functionality and thus would be a good addition here.

Not sure about the pip dependency in this file. Should live somewhere else?

cc @dhruvbalwada

Over at LEAP we have been testing https://github.com/yuvipanda/jupyter-sshd-proxy (thanks @yuvipanda )and it works really nicely to connect to cloud hubs e.g. using vscode. I think this is a pretty broadly requested functionality and thus would be a good addition here.

Not sure about the pip dependency in this file. Should live somewhere else?

cc @dhruvbalwada
@pangeo-bot
Copy link
Collaborator

/condalock
Automatically locking new conda environment, building, and testing images...

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Binder 👈 Try on Mybinder.org!

@yuvipanda
Copy link
Member

I love!

@@ -81,6 +81,9 @@ dependencies:
- panel
- parcels
- param
- pip
- pip:
jupyter-sshd-proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now in conda forge!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched the dependency!

@weiji14
Copy link
Member

weiji14 commented Oct 10, 2024

/condalock

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbusecke! I'll merge this in today, but will get @scottyhq to tag a new version (possibly after #584 is merged too).

@weiji14 weiji14 merged commit 1ac1baa into master Oct 10, 2024
5 checks passed
@weiji14 weiji14 deleted the jupyter-sshd-proxy branch October 10, 2024 22:41
@weiji14 weiji14 mentioned this pull request Oct 10, 2024
@jbusecke
Copy link
Collaborator Author

Thanks folks! Appreciate the quick turnaround!

yuvipanda added a commit that referenced this pull request Oct 26, 2024
Follow-up to #585 (comment).

The conda-forge package doesn't actually pull in openssh,
which feels like the right call for now (as systems may already
have openssh via other means?). 

Explicilty add openssh so jupyter-sshd-proxy works
scottyhq pushed a commit that referenced this pull request Oct 26, 2024
* Install openssh so jupyter-sshd-proxy could work

Follow-up to #585 (comment).

The conda-forge package doesn't actually pull in openssh,
which feels like the right call for now (as systems may already
have openssh via other means?). 

Explicilty add openssh so jupyter-sshd-proxy works

* [condalock-command] autogenerated conda-lock files

---------

Co-authored-by: pangeo-bot <pangeo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants