Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number overflow in the transaction deadline input #58

Open
R1nlz3r opened this issue Jun 21, 2021 · 1 comment
Open

Number overflow in the transaction deadline input #58

R1nlz3r opened this issue Jun 21, 2021 · 1 comment

Comments

@R1nlz3r
Copy link

R1nlz3r commented Jun 21, 2021

Description :
Hello, I tried to put random stuff into the "Transaction deadline" input to see if it breaks.
If you enter a too big number it overflows, throws an error, breaks the client side (blank screen) and stays in the cookie.
You have to delete your cookie to recover a normal state.
Putting some conditions in place to check if the input value is valid before processing it could solve the issue.

Path to input :
Transactions settings > Transactions deadline.

Steps to reproduce :
Copy / paste "999999999999999999" into the input.

@bmino
Copy link
Contributor

bmino commented Dec 14, 2021

Good find! Would you be able / willing to submit a PR to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants