chore. Update module and fix bugs in build #12
Conversation
|
Thank you. I'm running the tests. If all goes well, we merged it. |
|
Do you want to correct the errors yourself or do you want me to correct them? I'll be waiting for anything. |
If you can correct them I would appreciate it, if not, when I come home from work I will correct the errors. |
jorge990125
force-pushed
the
update
branch
4 times, most recently
from
3249cc3 to
579c184
Compare
The case was useful to me, to show how a person can contribute to another person's branch, even if that person did not create the pull request. But there is no rush, and other scenarios may arise in the future. That's why I asked you, to know if I should get involved or not. |
|
I left you some suggestions, none of them are really obligatory, they are more than anything recommendations, to respect the way of writing things, but none of them play a really important role in this case. |
I really like it when you give me advice since I don't know everything and every day you learn something new, learning from mistakes is wise, so any help I receive will always be appreciated. |
|
Don't worry about the number of commits that are formed within this pull request, because when the merge is performed, using the Squash and merge option, all the commits are combined into just 1, regardless of the number that have been generated within this branch. |
|
The tests passed without any problems. However, the changes I mentioned above would have to be made. I can do them myself, or if you want and have time, if you want to do them yourself, no problem. Let me know. I'll be waiting. |
|
Ok, if you can do it, I would appreciate it very much. |
Perfect, I'll do it. |
Most of the fixes in this commit are not important, except for the command fix. But the rest are more cosmetic, and to try to always write the code with the same format. As well as the issue of leaving the line break at the end of the document.
|
On GitHub, by default, there is an option configured to accept commits from other people on some branches. You have to check if you have that option enabled, because I think not. I don't remember if it can be enabled within each pull request, or if it is an account setting.
|
|
I already activated the option |
Perfect, I can now commit. Now we need to wait for the tests to pass, and check if there is anything else pending. I have to test in-game if it works, because I haven't tested it and since we made changes to the command, we will have to test that part. |
|
Apparently, there is a small failure, when using the command. But now I correct it. The rest, it seems that everything is fine. |
|
Done, it is now fixed, if it passes the tests, we merge it. |
|
Merged. Thanks. |
Changes Proposed:
getLevelmethod toGetLevelTests Performed:
How to Test the Changes: