Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid schema validation for @app block types #175

Open
davidwarrington opened this issue Oct 27, 2023 · 1 comment
Open

Invalid schema validation for @app block types #175

davidwarrington opened this issue Oct 27, 2023 · 1 comment
Labels
Bug Something isn't working in the vscode extension

Comments

@davidwarrington
Copy link
Collaborator

In a section schema this is a valid block type

{
  "type": "@app"
}

The extension throws a warning that this is missing the name property. For what it's worth name is also not valid on blocks with this type.
@davidwarrington davidwarrington added the Bug Something isn't working in the vscode extension label Oct 27, 2023
@panoply
Copy link
Owner

panoply commented Oct 28, 2023

Ouff. Good catch. Will patch and ship in v4.0.1

panoply added a commit to panoply/liquify-schema that referenced this issue Jun 14, 2024
@panoply
fixes app block validation per: panoply/vscode-liquid#175
2089e86 
CC David
panoply added a commit to panoply/liquify-schema that referenced this issue Jun 14, 2024
@panoply @davidwarrington
Fixes app type
f63dc54 
As per panoply/vscode-liquid#175

Co-Authored-By: David Warrington <9138568+davidwarrington@users.noreply.github.com>
panoply added a commit that referenced this issue Jun 14, 2024
@panoply @davidwarrington
fixes #189 and #175
0000cb5 
Co-Authored-By: David Warrington <9138568+davidwarrington@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working in the vscode extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panoply @davidwarrington