Plugin for modifying install_requirements
#20022
Unanswered
StefanUlbrich
asked this question in
Q&A
Replies: 3 comments
-
Hmmm. This whole area of how to use a generated setup.py but influence its arguments needs a bunch of work. Related issues: |
Beta Was this translation helpful? Give feedback.
0 replies
-
It's a common enough use case that we should have a proper API for it. I think I'd prefer that to hacking something in. |
Beta Was this translation helpful? Give feedback.
0 replies
-
But your general idea is in the right direction, I think. We need a hook to let you modify the generated kwargs, and we can make that clunky at first. So a proof-of-concept would be welcome! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Similar to writing plugins that add custom python_artifact() keywords, I want to modify the generated
install_requires
post inference (e.g., relax the version of an internal dependency).I think this can be achieved by adding the
@union
decorator toGenerateSetupPyRequest
(and maybe add anis_applicable
classmethod?). Then I could write a rule that callsdetermine_finalized_setup_kwargs
and modify the requires.This seems to me to be the only way to achieve my goal. I wonder, however, if it is too"hacky". Is it worth opening a pull request for this idea?
Beta Was this translation helpful? Give feedback.
All reactions