Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleaned up #37] update Papis Sci-Hub plugin #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hseg
Copy link

@hseg hseg commented Nov 15, 2023

Features:

  • Convert plugin from Importer to Downloader
  • Removed attempt to download from crossref first
  • Removed dependency on scihub, instead plugin scrapes the actual webpage
    using bs4
  • BibTeX metadata is pulled from https://doi.org
  • Update to use pyproject.toml instead of setup.py
  • Replace README.rst by README.md

Diff off original:

  • Restore static versions (at least until repo starts tagging versions)
    • Add (commented-out) [tool.setuptools_scm] section to silence
      warnings once repo uses dynamic versioning
  • Restore unnecessary edits
    • Restore liability warning
    • Restore version bounds (guessed for bs4)
    • Restore classifiers, keywords, authors
    • Relax python version bounds
    • Explicitly use standard GPL3 text
  • Make pylint-clean for python >=3.6
    • Convert | None to uses of Optional[] to silence warnings on
      Pythons older than 3.10
    • Use more specific exceptions
    • Clean up early-exit logic, drop useless exception catches
    • Standardize names
  • Misc improvements
    • Fix download_bibtex() type
    • Add sci-hub mirrors

Closes: #37

Raj Magesh Gauthaman and others added 4 commits November 15, 2023 23:45
* Restore static versions (at least until repo starts tagging versions)
  * Add (commented-out) [tool.setuptools_scm] section to silence
    warnings once repo uses dynamic versioning
* Restore unnecessary edits
  * Restore liability warning
  * Restore version bounds (guessed for bs4)
  * Restore classifiers, keywords, authors
  * Relax python version bounds
  * Explicitly use standard GPL3 text
* Make pylint-clean for python >=3.6
  * Convert `| None` to uses of `Optional[]` to silence warnings on
    Pythons older than 3.10
  * Use more specific exceptions
  * Clean up early-exit logic, drop useless exception catches
  * Standardize names
* Misc improvements
  * Fix `download_bibtex()` type
  * Add sci-hub mirrors
@hseg
Copy link
Author

hseg commented Nov 15, 2023

Would've squashed the original commits to prevent some of the noise, but wanted to preserve attribution.

@hseg
Copy link
Author

hseg commented Mar 5, 2024

Any updates on this? It should be a clean merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant