chore(sync): Delay shrinking db abstraction to revm::Database in execution
#13538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-staged-sync
mattsse
requested changes
Dec 24, 2024
There was a problem hiding this comment.
I think this is a pretty good change, offloading all the revm::Db stuff to the actual executor and instead provide the State, the fn get_state(State<) getters a re bit horrible but we had to add those, but I assume we could simplify these a bit later.
very supportive here
| @@ -60,7 +60,7 @@ pub trait Executor<DB> { | |||
| state: F, | |||
| ) -> Result<Self::Output, Self::Error> | |||
| where | |||
| F: FnMut(&State<DB>); | |||
| F: FnMut(&State<StateProviderDatabase<DB>>); | |||
There was a problem hiding this comment.
what I wanted to do for this for a while now is introduce a trait for State, which would make this a lot more ergonomic. so for now I'm fine with that
| @@ -152,6 +166,221 @@ impl<DB: DatabaseRef> Database for CachedReadsDbMut<'_, DB> { | |||
| } | |||
| } | |||
|
|
|||
| impl<DB: AccountReader> AccountReader for CachedReadsDbMut<'_, DB> { | |||
There was a problem hiding this comment.
do we need these?
ah we need these to satisfy the stateprovider trait?
but why do we need this traits now?
| @@ -164,6 +164,7 @@ where | |||
|
|
|||
| let EvmEnv { cfg_env_with_handler_cfg, block_env } = | |||
| self.eth_api().evm_config().cfg_and_block_env(block.header()); | |||
| // Note: we assume the block has a valid height | |||
There was a problem hiding this comment.
I believe this is a merge artifact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13537
revm::Databaseis a subset of theStateProviderbehaviour (EvmStateProvider). The database passed to execution in reth, implementsStateProvider, so this PR simply delays the step where the db is limited to therevm::Databasesubset of behaviour. This way we can now compute the state root (and storage root (OP)) in execution directly, which means we can verify the corresponding values in the block header against the correct state also in batch execution.