Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add L2EthApiExt trait #13539

Merged
merged 3 commits into from
Dec 24, 2024
Merged

feat: add L2EthApiExt trait #13539

merged 3 commits into from
Dec 24, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 24, 2024

towards #13488

introduces an extension trait for the eth_sendRawTransactionConditional endpoint

@mattsse mattsse requested a review from Rjected as a code owner December 24, 2024 10:37
@mattsse mattsse added A-rpc Related to the RPC implementation C-enhancement New feature or request labels Dec 24, 2024
@mattsse mattsse force-pushed the matt/add-l2ethapi-ext-trait branch from 2164032 to 35917d8 Compare December 24, 2024 10:52
@mattsse mattsse requested a review from klkvr December 24, 2024 12:56
@mattsse mattsse enabled auto-merge December 24, 2024 12:57
klkvr
klkvr approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 24, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Dec 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #13539 will improve performances by 11.08%

Comparing matt/add-l2ethapi-ext-trait (edabeab) with main (9773b85)

Summary

⚡ 2 improvements
✅ 75 untouched benchmarks

Benchmarks breakdown

Benchmark main matt/add-l2ethapi-ext-trait Change
⚡ `receipts root size: 10 HashBuilder` 123.1 µs
⚡ ordered_trie_root 141.7 µs 128.5 µs +10.29%

@mattsse mattsse merged commit a4410c8 into main Dec 24, 2024
43 checks passed
@mattsse mattsse deleted the matt/add-l2ethapi-ext-trait branch December 24, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @klkvr