Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax EngineNodeLauncher bounds #13540

Merged
merged 5 commits into from
Dec 24, 2024
Merged

chore: relax EngineNodeLauncher bounds #13540

merged 5 commits into from
Dec 24, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 24, 2024

The only reason we still need this bound to EthPrimitives is for maybe_reorg

Types: NodeTypesForProvider + NodeTypesWithEngine<Primitives = EthPrimitives>,

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 9773b85 Dec 24, 2024
44 checks passed
@mattsse mattsse deleted the klkvr/relax-launcher branch December 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants