Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct typo docs #13557

Merged
merged 5 commits into from
Dec 30, 2024
Merged

chore: correct typo docs #13557

merged 5 commits into from
Dec 30, 2024

Conversation

sky-coderay
Copy link
Contributor

Description

  • Corrected RCP to RPC
  • Corrected mesesages to messages
  • Corrected DAO_HARDKFORK_ACCOUNTS to DAO_HARDFORK_ACCOUNTS

I fixed the typos in the comments and also one in the function. I tried really hard—happy to help, thank you!

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally we would not accept purely typo fix PRs, but changing the name of this constant seems like an improvement and I can't stop seeing the typo now. We do need all usages of the constant changed, should also make sure it builds locally

@sky-coderay
Copy link
Contributor Author

@Rjected All references have been updated, the project builds successfully. Thanks

@@ -7,7 +7,7 @@ use alloy_primitives::{address, Address};
pub static DAO_HARDFORK_BENEFICIARY: Address = address!("bf4ed7b27f1d666546e30d74d50d173d20bca754");

/// DAO hardfork account that ether was taken and added to beneficiary
pub static DAO_HARDKFORK_ACCOUNTS: [Address; 116] = [
pub static DAO_HARDFORK_ACCOUNTS: [Address; 116] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rename has side effects. we also need to rename other occurrences of this constant

@mattsse
Copy link
Collaborator

mattsse commented Dec 28, 2024

needs cargo +nightly fmt

please don't open prs from main branch :)

@sky-coderay
Copy link
Contributor Author

@mattsse I ran cargo +nightly fmt and everything seems fine. Should I rebase now?

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me now - no rebase is needed now, but future PRs should be opened from a branch of your personal fork. This is so that we can make touchups if needed :)

@Rjected Rjected added this pull request to the merge queue Dec 30, 2024
Merged via the queue into paradigmxyz:main with commit 00ad7f6 Dec 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants