feat(tree): when comparing trie updates, check the database #13765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/tree-trie-updates-database
branch
from
c60d8ca to
8c3a28d
Compare
shekhirin
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
rkrasiuk
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of trie update mismatches that are caused by the fact that either Sparse Trie or Hash Builder update a branch node with the same value as it is in the database, which is basically a no-op.
The changes in this PR check the database and if the node didn't change, don't add to diffs. Additionally, we now log the database entry for branch nodes.