Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo-tarpaulin version to 0.26.1 #701

Conversation

tgonzalezorlandoarm
Copy link
Member

 * Create an environment variable to define the MSRV so that only
   one change is needed to update it.
 * Fix the version of cargo-tarpaulin to 0.26.1

Signed-off-by: Tomás González tomasagustin.gonzalezorlando@arm.com

@tgonzalezorlandoarm tgonzalezorlandoarm requested a review from a team as a code owner September 21, 2023 14:38
@tgonzalezorlandoarm tgonzalezorlandoarm added the dependencies Pull requests that update a dependency file label Sep 21, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Sep 21, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm added the testing Task related to testing label Sep 21, 2023
Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

Currently, to update the MSRV, several places in the ci.sh script
need to be changed.

 * Create an environment variable to define the MSRV so that only
   one change is needed to update it.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
The nightly coverage build is currently failing as it is failing to
compile the cargo-tarpaulin crate 0.27.0 with the rust compiler
1.66 (our current MSRV). We cannot upgrade the current MSRV because
certain distros need that version, so we can only:

 * Fix the version of cargo-tarpaulin to 0.26.1

This version should be unfixed when the MSRV upgrade is performed.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/fix-cargo-tarpaulin-version branch from d9fb626 to 8b34f74 Compare September 25, 2023 15:24
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 56e95a7 into parallaxsecond:main Sep 25, 2023
13 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/fix-cargo-tarpaulin-version branch October 26, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file testing Task related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants