Move MSRV to 1.60.0 #419
Merged
Move MSRV to 1.60.0 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our dependency on the `log` crate means that currently the crate does not compile with our MSRV. It makes more sense for us to bump the MSRV and stay aligned with updates of `log`. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
wiktor-k
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
It's kind of crazy to update because of the log crate but lets check the facts: 1.60 was released on Apr. 7, 2022 (https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html). We use the same version in Sequoia (https://gitlab.com/sequoia-pgp/sequoia#requirements-and-msrv) and we are very conservative in this aspect.
So I'm very much in favor! 👍
Superhepper
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our dependency on the
logcrate means that currently the crate does not compile with our MSRV. It makes more sense for us to bump the MSRV and stay aligned with updates oflog.