Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the serde dependency optional. #526

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Superhepper
Copy link
Collaborator

@Superhepper Superhepper commented Jun 1, 2024

This fixes #525 adding the serde feature which when enabled makes it possible to serialize
and deserialize the types that previously
supported it automatically.

@Superhepper Superhepper force-pushed the optional-serde branch 8 times, most recently from 70b7338 to 12218e5 Compare June 3, 2024 18:25
@Superhepper Superhepper marked this pull request as ready for review June 3, 2024 19:19
wiktor-k
wiktor-k previously approved these changes Jun 4, 2024
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks! (I've been looking at cutting serde usage in my crates too so it's nice to see it here!)

tss-esapi/tests/coverage.sh Outdated Show resolved Hide resolved
ionut-arm
ionut-arm previously approved these changes Jun 7, 2024
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thank you!

@Superhepper Superhepper requested a review from wiktor-k June 7, 2024 16:06
This fixes parallaxsecond#525 adding the `serde` feature
which when enabled makes it possible to serialize
and deserialize the types that previously
supported it automatically.

Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@ionut-arm ionut-arm merged commit 1411c46 into parallaxsecond:main Jun 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the serde dependency optional.
3 participants