[stable] Remove preload.js path verification (#140)

* Remove preload.js path verification * Bump v0.1.4
parity-js · Jun 11, 2018 · d199ccf · d199ccf
1 parent b002de1
commit d199ccf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "parity-ui",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "The Electron app for Parity UI",
   "main": ".build/electron.js",
   "jsnext:main": ".build/electron.js",

diff --git a/src/index.electron.js b/src/index.electron.js
@@ -112,14 +112,9 @@ function createWindow () {
   mainWindow.webContents.on('will-attach-webview', (event, webPreferences, params) => {
     // Strip away inline preload scripts, ours is at preloadURL
     delete webPreferences.preload;
-    // Verify the location of our prelaod script is legitimate (unless uiDev has been passed)
-    if (webPreferences.preloadURL !== encodeURI(url.format({
-      pathname: path.join(__dirname, 'preload.js'),
-      protocol: 'file:',
-      slashes: true
-    }))) {
-      throw new Error(`Unknown preload.js is being injected, quitting for security reasons. ${webPreferences.preloadURL}`);
-    }
+
+    // TODO Verify that the location of webPreferences.preloadURL is:
+    // `file://path/to/app.asar/.build/preload.js`
 
     // Disable Node.js integration
     webPreferences.nodeIntegration = false;