Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new polkadot binaries split #41

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

BulatSaif
Copy link
Contributor

@BulatSaif BulatSaif commented Aug 8, 2023

Fixes #40

Changes:

  1. Fixed a typo in the key inject role.
  2. Adapted to the new binary split for validators.
  3. Added migration checks: After downloading the new binary, the help command is used to verify the presence of necessary flags. We check --help output instead of the --version since the role may deploy any Substrate chain, and the version format can vary.

Tests

I used a binary from the master branch (link may have expired): Binary Link

Case 1:
Using the old ansible role results in a failure:

2023-08-08 16:37:33.992  WARN tokio-runtime-worker sc_service::builder: The NetworkStart returned as part of `build_network` has been silently dropped
Error:
   0: Worker binaries could not be found. Ensure that polkadot was built/installed correctly. Searched given workers path (None), polkadot binary path ("/home/parity/bin"), and lib path (/usr/lib/polkadot), worker names: None

Case 2:
Using the new ansible role from this branch results in successful application execution:

2023-08-08 16:31:26.134  INFO main polkadot_service: 🚀 Using the prepare-worker binary at: "/home/parity/bin/polkadot-prepare-worker"
2023-08-08 16:31:26.134  INFO main polkadot_service: 🚀 Using the execute-worker binary at: "/home/parity/bin/polkadot-execute-worker"

@BulatSaif BulatSaif self-assigned this Aug 8, 2023
@BulatSaif BulatSaif changed the title Adapt to new binaries split for validators #40 Adapt to new binaries split for validators Aug 8, 2023
Co-authored-by: Pierre Besson <pierre.besson@parity.io>
@PierreBesson PierreBesson changed the title Adapt to new binaries split for validators Adapt to new polkadot binaries split Aug 9, 2023
@BulatSaif BulatSaif merged commit e00fadd into main Aug 9, 2023
4 checks passed
@BulatSaif BulatSaif deleted the bs/40-separate_binary branch August 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to new binaries split for validators
3 participants