Skip to content

Commit

Permalink
updated dependencies (#10)
Browse files Browse the repository at this point in the history
Updated action dependencies to be in sync with other projects.

Updated docker image to be 20
  • Loading branch information
Bullrich authored Mar 14, 2024
1 parent b5dcdaa commit fe7e0a7
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 35 deletions.
56 changes: 26 additions & 30 deletions .github/workflows/javascript-test.yml
Original file line number Diff line number Diff line change
@@ -1,43 +1,39 @@
name: Continuous testing

on: [pull_request]
on:
pull_request:
push:
branches: ["main"]

jobs:
lint:
test:
strategy:
matrix:
command: [lint, build, test]
runs-on: ubuntu-latest
name: running ${{ matrix.command }}
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
- uses: actions/checkout@v4.1.1
- uses: actions/setup-node@v4.0.2
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run lint

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
node-version: 20
- name: Cache node modules
id: cache-npm
uses: actions/cache@v4
env:
cache-name: cache-node-modules
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: ${{ runner.os }}-build-${{ env.cache-name }}-
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run build
- run: yarn run ${{ matrix.command }}

test:
conclude:
runs-on: ubuntu-latest
name: All tests passed
needs: [test]
steps:
- uses: actions/checkout@v3
- name: Use node 18
uses: actions/setup-node@v3
with:
node-version: 18
- uses: c-hive/gha-yarn-cache@v2
- name: Install dependencies
run: yarn install --frozen-lockfile
- run: yarn run test
- run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
test-image:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1
- name: Check that the image builds
run: docker build . --file Dockerfile

Expand All @@ -23,7 +23,7 @@ jobs:
version: ${{ steps.verification.outputs.VERSION }}
exists: ${{ steps.checkTag.outputs.exists }}
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1
- name: Extract package.json version
id: package_version
run: echo "VERSION=$(jq '.version' -r package.json)" >> $GITHUB_OUTPUT
Expand All @@ -48,7 +48,7 @@ jobs:
contents: write
packages: write
steps:
- uses: actions/checkout@v3.3.0
- uses: actions/checkout@v4.1.1
- name: Tag version and create release
run: gh release create $VERSION --generate-notes
env:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18 as Builder
FROM node:20 as Builder

WORKDIR /action

Expand All @@ -10,7 +10,7 @@ COPY . .

RUN yarn run build

FROM node:18-slim
FROM node:20-slim

COPY --from=Builder /action/dist /action

Expand Down

0 comments on commit fe7e0a7

Please sign in to comment.